fix: escape BRE special characters when selecting author from suggestions#2494
Merged
love-linger merged 1 commit intoJun 29, 2026
Merged
Conversation
love-linger
added a commit
that referenced
this pull request
Jun 29, 2026
Since `EscapeForBRE` is only used when selecting item in suggestion popup (and the searching command runs immediately after it), directly call `EscapeForBRE` to generate the searching filter Signed-off-by: leo <longshuang@msn.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a
Usersuggestion (e.g.github-actions[bot]) is selected in the author search,the filter is passed directly to
git log --author=as a POSIX BRE pattern.[bot]is interpreted as a character class, so no commits are found.Solution
EscapeForBRE()toStringExtensionsto escape BRE special characters_isLiteralFilterfield andSetLiteralFilter()toSearchCommitContextSetLiteralFilter()when aUsersuggestion is selected;StartSearch()thenapplies
EscapeForBRE()before passing the filter togit log --author=_isLiteralFilter, preserving BRE regex for power users